-
Notifications
You must be signed in to change notification settings - Fork 45
fix: ensure all prod/dev/uat deployments #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughThe Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
π§Ή Nitpick comments (1)
src/main/environment/common_ci.properties (1)
171-171
: Add explanatory comment: Clarify thatisProduction=true
is intended for Production and UAT environments, and that development environments must override it if needed.Proposed diff:
- isProduction=true + # Enable production mode for Production and UAT; dev environments should override as needed + isProduction=true
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
π Files selected for processing (1)
src/main/environment/common_ci.properties
(1 hunks)
β° Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Package-test
- GitHub Check: Analyze (java)
- GitHub Check: Build
π Additional comments (1)
src/main/environment/common_ci.properties (1)
171-171
:β Verification inconclusive
Confirm environment-specific override: Ensure that setting
isProduction=true
in this common CI configuration does not unintentionally apply to development deploymentsβverify that dev environments use a separate properties file or override this flag appropriately.Run this script to locate all occurrences and confirm proper overrides:
π Script executed:
#!/bin/bash # Search for references to isProduction across the codebase rg -n 'isProduction' .Length of output: 413
Verify
isProduction
override per environment
I ran a search (rg -n 'isProduction' .
) and found:
- src/main/environment/common_ci.properties:171 β
isProduction=true
- src/main/environment/common_example.properties:195 β
isProduction=false
- CookieUtil.java reads this value via
@Value("${isProduction}")
.Confirm that your configuration only loads
common_ci.properties
in CI pipelines and that development runs load the example/dev properties (or another profile-specific file) to overrideisProduction=false
. This ensures the flag isnβt unintentionally set totrue
in non-production environments.
π Description
JIRA ID:
Always ensure production is set as true for production/uat deployments
β Type of Change
Summary by CodeRabbit