Skip to content

added some minor fixes in VersionController.java file #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

added some minor fixes in VersionController.java file #89

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89ee8f0
added some minor fixes in VersionController.java file
Rishav123raj Apr 13, 2025
cb287ab
added import for FileNotFound Exception
Rishav123raj Apr 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/main/java/com/iemr/common/identity/controller/version/VersionController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.io.FileNotFoundException;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand All @@ -39,11 +40,11 @@
@RestController
public class VersionController {

private Logger logger = LoggerFactory.getLogger(this.getClass().getSimpleName());
private static final Logger logger = LoggerFactory.getLogger(VersionController.class);

@CrossOrigin()
@Operation(summary = "Get version information")
@GetMapping(value = "/version",consumes = "application/json", produces = "application/json")
@GetMapping(value = "/version", produces = "application/json")
public String versionInformation() {
OutputResponse output = new OutputResponse();
try {
Expand All @@ -59,7 +60,10 @@ public String versionInformation() {
private String readGitProperties() throws Exception {
ClassLoader classLoader = getClass().getClassLoader();
InputStream inputStream = classLoader.getResourceAsStream("git.properties");

if (inputStream == null) {
throw new FileNotFoundException("git.properties file not found in classpath");
}

return readFromInputStream(inputStream);
}
private String readFromInputStream(InputStream inputStream)
Expand Down