Skip to content

Conversation

Zapper9982
Copy link
Contributor

PR: Complete Controller Test Coverage for MMU-API

📋 Description

JIRA ID:

This PR adds complete unit test coverage for all controller classes in the MMU-API project. The motivation behind this change is to ensure robust validation of all controller endpoints, covering all logic branches, error handling, and exception scenarios. This improves code reliability, maintainability, and confidence in future changes.


✅ Type of Change

  • 🐞 Bug fix (non-breaking change which resolves an issue)
  • New feature (non-breaking change which adds functionality)
  • 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🛠 Refactor (change that is neither a fix nor a new feature)
  • ⚙️ Config change (configuration file or build script updates)
  • 📚 Documentation (updates to docs or readme)
  • 🧪 Tests (adding new or updating existing tests)
  • 🎨 UI/UX (changes that affect the user interface)
  • 🚀 Performance (improves performance)
  • 🧹 Chore (miscellaneous changes that don't modify src or test files)

ℹ️ Additional Information

All controller methods are now covered by comprehensive unit tests using MockMvc and Mockito. Tests include all success, error, and exception branches. The test suite passes with 100% coverage for controller logic.
No production code was modified—only test files were added or updated.
See test run output and coverage reports for details.

Screenshots

  • Build Success

image
  • JaCoCo Report

image image

@drtechie @vanitha1822

Copy link

coderabbitai bot commented Aug 14, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Zapper9982
Copy link
Contributor Author

@vanitha1822 can u guide me on what should I do about the merge conflicts they are minor changes on the controller , for
better error handling . can u review them

@vanitha1822
Copy link
Contributor

@vanitha1822 can u guide me on what should I do about the merge conflicts they are minor changes on the controller , for better error handling . can u review them

@Zapper9982 Do the 'Sync repo' from your forked repo and then take the latest pull from release-3.4.0 and resolve them in merge editor. It is easy for you to identify the changes.

@vanitha1822
Copy link
Contributor

@Zapper9982 please resolve the conflicts

@Zapper9982
Copy link
Contributor Author

@Zapper9982 please resolve the conflicts

sure will do it by tonight .

Copy link

sonarqubecloud bot commented Sep 3, 2025

@drtechie drtechie changed the base branch from release-3.4.0 to main October 9, 2025 07:55
@drtechie drtechie merged commit 94e4ddb into PSMRI:main Oct 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants