Skip to content

[Urgent] Add out params to some apis #13561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2018
Merged

[Urgent] Add out params to some apis #13561

merged 1 commit into from
Sep 25, 2018

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Sep 25, 2018

No description provided.

@sneaxiy sneaxiy requested review from reyoung and removed request for ktlichkid September 25, 2018 06:36
@panyx0718
Copy link
Contributor

why is this urgently needed? I think it's ok to just return out?

@velconia
Copy link
Collaborator

Because the param out was depended by optimizer and will cause models CE job fails

@sneaxiy sneaxiy merged commit 2cd558f into PaddlePaddle:develop Sep 25, 2018
@sneaxiy sneaxiy deleted the fix_api_kwargs branch October 17, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingqing01 qingqing01 qingqing01 approved these changes

@panyx0718 panyx0718 Awaiting requested review from panyx0718

@reyoung reyoung Awaiting requested review from reyoung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sneaxiy @panyx0718 @velconia @reyoung @qingqing01