Fix/Fix memory leak in dygraph #17394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature/sorted_gradient_dygraph
… feature/sorted_gradient_dygraph
… feature/sorted_gradient_dygraph
sneaxiy
reviewed
May 14, 2019
paddle/fluid/imperative/layer.cc
Outdated
| bck_map = new BackwardSumMap(); | ||
| grad_ref = new GradientRef(); | ||
| bck_map = BackwardSumMap(); | ||
| grad_ref = GradientRef(); |
There was a problem hiding this comment.
These two lines are unnecessary. BTW, it seems that it is not necessary thatbck_map and grad_ref are data member of Autograd. Just make them temporary variable inside the function.
sneaxiy
reviewed
May 14, 2019
paddle/fluid/imperative/layer.cc
Outdated
| if (grad_ref->find(vb) == grad_ref->end()) { | ||
| grad_ref->insert(std::make_pair(vb, 1)); | ||
| if (grad_ref.find(vb) == grad_ref.end()) { | ||
| grad_ref.insert(std::make_pair(vb, 1)); |
There was a problem hiding this comment.
C++ guarantees zero-initialization of primitive types. See here. You can just write ++grad_ref[vb];
paddle/fluid/imperative/layer.cc
Outdated
| BackwardSumMap* bck_map; | ||
| GradientRef* grad_ref; | ||
| BackwardSumMap bck_map; | ||
| GradientRef grad_ref; |
There was a problem hiding this comment.
No need to be data members.
JiabinYang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix memory leak problem in dygraph mode and using
unique_ptrto holdVariableto make sure it can be freed automatically whenVarbaseis released by python gc