-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Implement FunctionTraits to support two kinds of elementwise functor and remove some old codes for broadcast. #35688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ This PR's description meets the template requirements! |
Thanks for your contribution! |
zhangting2020
approved these changes
Sep 14, 2021
chenwhql
approved these changes
Sep 14, 2021
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
…and remove some old codes for broadcast. (PaddlePaddle#35688)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
重新实现#35487 ,解决编译错误(#35686)。
#35487 引入了一个
FunctionTraits
,对于重载了operator()
的Functor,可以在编译时静态获取Functor的2个特征,并写入静态变量:(1)operator()
的参数个数arity(2)operator()
有且只有一个参数时,第一个参数是否是指针类型,用以在Elementwise实现中,支持如下形式的Functor,以支持任意元计算#35487 中定义的
FunctionTraits
要求operator()
必须定义成const,#35635 中使用了非const的Functor,所以发生了编译错误。本PR主要工作是:加强FunctionTraits,支持非const的operator()
。