refine optimizer create accumulators #50188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
veyron95
added a commit
to veyron95/Paddle
that referenced
this pull request
Feb 23, 2023
This reverts commit 244e754.
phlrain
pushed a commit
that referenced
this pull request
Feb 24, 2023
* Revert "fixoptminizer _set_auxiliary_var bug (#50335)" This reverts commit c44005f. * Revert "refine optimizer create accumulators (#50188)" This reverts commit 244e754. * Revert "fix found_inf bug for custom optimizer (#50158)" This reverts commit 64573f9. * Revert "refine amp scaler found_inf (#49864)" This reverts commit 382e9a0. * fix code format * fix conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
Others
Describe
重复的create accumulators造成了optimizer的性能下降。本PR优化一下。
以adam举例优化前timeline如下：
优化后timeline如下：