-
Notifications
You must be signed in to change notification settings - Fork 5.7k
fix_StackOverFlow_Case6 #50427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix_StackOverFlow_Case6 #50427
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
麻烦把case加到单测里吧~
您好,我看了下test_lbfgs.py,发现有单测,用的dot,dot的单测里已有对输入X和Y的测试 |
我是说把这个case加到单测中,一方面证明这个PR的修改能够修复这个case。另一方面也对这种场景加以保护。
|
收到! |
我发现这个case在新的版本编译后,已经修复了。好像不用再修了。 |
@veyron95 请帮忙确认下~ |
PR types
Bug fixes
PR changes
OPs
Describe
Solution
Cause original code compare the input x dims size is equal to it's self.
but in code ,when x and y all input x . if x dim is [1,1] ,y is [1], is not equal .
So delete this code. Add code to judge y dim.