Skip to content

fix: fix deformable_conv_grad op test #53415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shengxiangwang
Copy link
Contributor

@shengxiangwang shengxiangwang commented Apr 27, 2023

PR types

Bug fixes

PR changes

OPs

Description

fix deformable_conv_grad op test.

  1. update XPU toolchain date, new version includes fixed op
  2. modify epsilon_xpu2xpu to e-6, beacuse there are some atomic add in this op.

@paddle-bot
Copy link

paddle-bot bot commented Apr 27, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Apr 27, 2023
@paddle-bot
Copy link

paddle-bot bot commented Apr 27, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@shengxiangwang
Copy link
Contributor Author

@paddle-bot
Copy link

paddle-bot bot commented Apr 27, 2023

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨原生算子开发规范,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@@ -138,6 +138,8 @@ def __init__(self):
class TestModulatedDeformableConvOp(XPUOpTest):
def setUp(self):
self.op_type = "deformable_conv"
# set to e-6 because of atomic add in XPU
self.epsilon_xpu2xpu = 0.000001
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有跑实际模型测试吗

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试了,edvr。

@QingshuChen QingshuChen merged commit 207e0f3 into PaddlePaddle:develop Apr 28, 2023
@paddle-bot
Copy link

paddle-bot bot commented Apr 28, 2023

你的PR已合入Paddle库,请关注后续测试结果。
Your PR has been merged into the repository. An official integration test will be conducted later. Stay tuned.

@shengxiangwang shengxiangwang deleted the fix/deformable_conv_grad_test branch May 12, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants