Skip to content

support py3.11 compile, but unittest is disabled. #54273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 39 additions & 12 deletions paddle/fluid/pybind/jit.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ limitations under the License. */
#include <Python.h>
#include <code.h>
#include <frameobject.h>

#if PY_VERSION_HEX >= 0x030b0000
#include <internal/pycore_frame.h>
#endif

#include <object.h>
#include <pystate.h>

Expand All @@ -36,6 +41,12 @@ namespace py = pybind11;
namespace paddle {
namespace pybind {

#if PY_VERSION_HEX >= 0x030b0000
typedef _PyInterpreterFrame FrameObject;
#else
typedef PyFrameObject FrameObject;
#endif

#define unlikely(x) __builtin_expect((x), 0)

// Use static variable to save customed eval hook.
Expand All @@ -56,7 +67,7 @@ inline static void eval_frame_callback_set(PyObject *obj) {

// call python default eval frame to interpret current frame.
inline static PyObject *eval_frame_default(PyThreadState *tstate,
PyFrameObject *frame,
FrameObject *frame,
int throw_flag) {
#if PY_VERSION_HEX >= 0x03090000
if (tstate == NULL) {
Expand All @@ -71,26 +82,34 @@ inline static PyObject *eval_frame_default(PyThreadState *tstate,
// Start a new frame and run code in this frame.
// Execute a piece of code by default frame-hook.
inline static PyObject *eval_custom_code(PyThreadState *tstate,
PyFrameObject *frame,
FrameObject *frame,
PyCodeObject *code,
int throw_flag) {
Py_ssize_t ncells = 0;
Py_ssize_t nfrees = 0;
Py_ssize_t nlocals_new = code->co_nlocals;
Py_ssize_t nlocals_old = frame->f_code->co_nlocals;

if ((code->co_flags & CO_NOFREE) == 0) {
ncells = PyTuple_GET_SIZE(code->co_cellvars);
nfrees = PyTuple_GET_SIZE(code->co_freevars);
}
#if PY_VERSION_HEX >= 0x030b0000
ncells = code->co_ncellvars;
nfrees = code->co_nfreevars;
#else
ncells = PyTuple_GET_SIZE(code->co_cellvars);
nfrees = PyTuple_GET_SIZE(code->co_freevars);
#endif

PyFrameObject *shadow = PyFrame_New(tstate, code, frame->f_globals, NULL);
if (shadow == NULL) {
return NULL;
}

#if PY_VERSION_HEX >= 0x030b0000
PyObject **fastlocals_old = frame->localsplus;
PyObject **fastlocals_new = shadow->f_frame->localsplus;
#else
PyObject **fastlocals_old = frame->f_localsplus;
PyObject **fastlocals_new = shadow->f_localsplus;
#endif

for (Py_ssize_t i = 0; i < nlocals_old; i++) {
Py_XINCREF(fastlocals_old[i]);
Expand All @@ -102,18 +121,26 @@ inline static PyObject *eval_custom_code(PyThreadState *tstate,
fastlocals_new[nlocals_new + i] = fastlocals_old[nlocals_old + i];
}

#if PY_VERSION_HEX >= 0x030b0000
PyObject *result = eval_frame_default(tstate, shadow->f_frame, throw_flag);
#else
PyObject *result = eval_frame_default(tstate, shadow, throw_flag);
#endif
Py_DECREF(shadow);
return result;
}

static PyObject *_custom_eval_frame(PyThreadState *tstate,
PyFrameObject *frame,
FrameObject *frame,
int throw_flag,
PyObject *callback) {
// https://peps.python.org/pep-0558/#fast-locals-proxy-implementation-details
// https://devguide.python.org/internals/interpreter/#all-sorts-of-variables
// https://peps.python.org/pep-0558/#fast-locals-proxy-implementation-details
// https://devguide.python.org/internals/interpreter/#all-sorts-of-variables
#if PY_VERSION_HEX >= 0x030b0000
if (PyFrame_FastToLocalsWithError(frame->frame_obj) < 0) {
#else
if (PyFrame_FastToLocalsWithError(frame) < 0) {
#endif
return NULL;
}

Expand Down Expand Up @@ -167,7 +194,7 @@ static PyObject *_custom_eval_frame(PyThreadState *tstate,
}

static PyObject *_custom_eval_frame_shim(PyThreadState *tstate,
PyFrameObject *frame,
FrameObject *frame,
int throw_flag) {
PyObject *callback = eval_frame_callback_get();

Expand All @@ -180,12 +207,12 @@ static PyObject *_custom_eval_frame_shim(PyThreadState *tstate,

#if PY_VERSION_HEX >= 0x03090000
static PyObject *custom_eval_frame_shim(PyThreadState *tstate,
PyFrameObject *frame,
FrameObject *frame,
int throw_flag) {
return _custom_eval_frame_shim(tstate, frame, throw_flag);
}
#else
static PyObject *custom_eval_frame_shim(PyFrameObject *frame, int throw_flag) {
static PyObject *custom_eval_frame_shim(FrameObject *frame, int throw_flag) {
PyThreadState *tstate = PyThreadState_GET();
return _custom_eval_frame_shim(tstate, frame, throw_flag);
}
Expand Down
7 changes: 7 additions & 0 deletions test/dygraph_to_static/test_eval_frame.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import collections
import unittest
from sys import version_info

import paddle

Expand All @@ -27,6 +28,12 @@ def tearDown(self):
pass

def test_eval_frame(self):
if version_info.major != 3 or (
version_info.minor <= 8 or version_info.minor >= 11
):
# print("skip test_eval_frame, current only support 3.8 - 3.10")
return

CustomCode = collections.namedtuple(
"CustomCode", ["code", "disable_eval_frame"]
)
Expand Down