[CINN]backend support stmt to expr visitor and run on func body #70739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
reviewed
Jan 9, 2025
Comment on lines
+84
to
+87
| class ExprPass : public Pass<ir::Expr*> { | ||
| public: | ||
| explicit ExprPass(const std::string& name) : Pass(PassKind::PK_STMT, name) {} | ||
| virtual LogicalResult Run(ir::Expr expr) = 0; | ||
| virtual LogicalResult Run(ir::Expr* expr) = 0; |
There was a problem hiding this comment.
Expr本身已经是一个指针类型了，为什么要换成Expr*类型？
There was a problem hiding this comment.
因为现有的对Expr的操作是允许inplace替换的，直接把这个指针改成新的指针了，要兼容这种替换必须用Expr*，否则底层对Expr的Visitor也需要全部升级改造重写允许返回值
There was a problem hiding this comment.
允许返回值的Visitor的问题是什么？为什么不选用这个方式
There was a problem hiding this comment.
成本问题，需要把对所有Expr的访问再升级改造
zyfncg
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Improvements
Description
pcard-67164
This PR Improves CINN backend IR in the following part: