Skip to content

Integrate FlagCX into Paddle #71507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from

Conversation

mikethegoblin
Copy link
Contributor

PR Category

Communication Library

PR Types

New features

Description

Integrate FlagCX into Paddle

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

paddle-bot bot commented Mar 9, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Mar 9, 2025
Copy link
Contributor

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单测:还需要增加单测验证所有通信接口,包括 send recv Allgather reducescatter

@liym27 liym27 requested a review from zhiqiu March 14, 2025 12:25
phlrain
phlrain previously approved these changes Mar 18, 2025
Copy link
Collaborator

@phlrain phlrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for flags

liym27
liym27 previously approved these changes Mar 18, 2025
Copy link
Contributor

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikethegoblin mikethegoblin dismissed stale reviews from liym27 and phlrain via 95e8b1d March 18, 2025 06:31
From00
From00 previously approved these changes Mar 18, 2025
Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

liym27
liym27 previously approved these changes Mar 18, 2025
Copy link
Contributor

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlrain phlrain self-requested a review March 18, 2025 14:04
phlrain
phlrain previously approved these changes Mar 18, 2025
XiaoguangHu01
XiaoguangHu01 previously approved these changes Mar 18, 2025
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

luotao1
luotao1 previously approved these changes Mar 18, 2025
ForFishes
ForFishes previously approved these changes Mar 18, 2025
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sneaxiy
sneaxiy previously approved these changes Mar 19, 2025
Copy link

paddle-ci-bot bot commented Apr 3, 2025

Sorry to inform you that b64dc67's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants