[SOT] Add tracker for generator in Python 3.11+ #71777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug involving generator tracking for Python 3.11+ by adding a tracker on the call side of inline generator execution.
- Updates callable.py to retrieve the generator from the inline executor, verify its type, and assign it a tracker.
- Modifies opcode_inline_executor.py to remove the use of DummyTracker in favor of DanglingTracker.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python/paddle/jit/sot/opcode_translator/executor/variables/callable.py | Adds type assertion for generator and assigns a tracker to the returned generator. |
| python/paddle/jit/sot/opcode_translator/executor/opcode_inline_executor.py | Switches tracker initialization from DummyTracker to DanglingTracker in RETURN_GENERATOR. |
| assert isinstance( | ||
| gen, GeneratorVariable | ||
| ), f"GeneratorFunction calling result should be GeneratorVariable, but got {type(gen)}" | ||
| gen.tracker = DummyTracker([self, *args, *kwargs.values()]) |
There was a problem hiding this comment.
The tracker's type is assigned using DummyTracker here, while in opcode_inline_executor.py, a DanglingTracker is used. This inconsistency may lead to unexpected behavior.
Suggested change
| gen.tracker = DummyTracker([self, *args, *kwargs.values()]) | |
| gen.tracker = DanglingTracker([self, *args, *kwargs.values()]) |
Copilot uses AI. Check for mistakes.
gouzil
approved these changes
Mar 20, 2025
SigureMo
changed the title
DrRyanHuang
approved these changes
Mar 20, 2025
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
之前 #71644 的 TODO 忘记了，补一下，在调用侧添加 tracker