[AutoParallel] Fix st save dy load in pir #72023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the static save and dynamic load process by removing a redundant _is_initialized check during parameter state matching in the Auto Parallel module.
- Removed unnecessary condition that skipped uninitialized parameter tensors
- Ensured that parameter state is updated after param.set_value(state)
Comments suppressed due to low confidence (1)
python/paddle/nn/layer/layers.py:2227
- Consider adding tests to verify that removing the _is_initialized() check does not lead to issues when uninitialized parameters are present.
for key, param in self._state_dict_impl(use_hook=False).items():
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Auto Parallel
PR Types
Bug fixes
Description
Fix static save dynamic load bug in pir.
Remove redundant
_is_initializedcheck that skips param_state matching.The param becomes initialized after
param.set_value(state)in the following lines.Pcard-70448