[XPU] update StridedCopyKernel #72030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houj04
requested review from
risemeup1,
zhangbo9674 and
XieYunshen
as code owners
|
你的PR提交成功，感谢你对开源项目的贡献! |
changeyoung98
previously approved these changes
Apr 2, 2025
Comment on lines
56
to
57
| // 下述XPU算子有性能问题，因此暂时禁用掉，改成“先拷贝到CPU，按照CPU算子逻辑计算，再拷贝回XPU”的临时方案 | ||
| /* |
There was a problem hiding this comment.
目前Paddle repo里暂时没有中文注释，换成英文吧~
|
|
||
| // CPU buffer for out | ||
| char* output_on_cpu = new char[out->Holder()->size()]; | ||
| memory_utils::Copy(CPUPlace(), |
There was a problem hiding this comment.
这里需要Wait一下吗？我看底层用的是xpu_memcpy_async。
一般，在Kernel中我们使用phi::Copy，如果给phi::Copy传入Stream则代表不blocking，如果stream为Nullptr，表示需要Blocking。
There was a problem hiding this comment.
如单独沟通，继续保留使用memory_utils::Copy，并且补充了同步操作。
QingshuChen
approved these changes
Apr 3, 2025
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
* [XPU] update StridedCopyKernel * fix ut env * follow comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Custom Device
PR Types
Performance
Description
目前
phi::StridedCopyKernel的XPU实现中，会使用xpu::strided_copy函数。该函数有严重的性能问题，因此暂时禁用掉，改成“先拷贝到CPU，按照CPU算子逻辑计算，再拷贝回XPU”的临时方案。由于有其它一批XPU下面的单测，仅能在
export FLAGS_use_stride_kernel=0的时候通过，因此本PR先修改了test_setitem_appendix单个单测的运行时环境变量。