[CINN] [New Hardware Update]Clean obsolete HIP Reduce templates #72142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
ZhangX-21
reviewed
Apr 14, 2025
| @@ -48,7 +48,6 @@ ir::Module CreateSwitchWithBroadcastConditionModule( | |||
| const auto &symbolic_arg_define = [&]() -> std::vector<ir::Expr> { | |||
| std::vector<ir::Expr> arg_defs; | |||
| for (const auto &item : symbolic_shape_var_index) { | |||
| #ifdef CINN_WITH_CUDA | |||
There was a problem hiding this comment.
call Node 不需要区分CUDA runtime::intrinsic::get_value_in_cuda_kernel_args和HIP/SYCL的区别吗？
| @@ -366,7 +353,6 @@ void detail::CollectBucketStrategyHostFunctionVisitor::ProcessArgs( | |||
| const std::vector<ir::Argument> &args = func->args; | |||
| for (int i = 0; i < args.size(); ++i) { | |||
| if (args[i].is_var()) { | |||
| #ifdef CINN_WITH_CUDA | |||
| @@ -68,27 +68,11 @@ class CodeGenSwitchHost : public CodeGenInvokeModule { | |||
| : CodeGenInvokeModule(m, b, vars) {} | |||
| // only support call of args get function and inner case host function call | |||
| llvm::Value *Visit(const ir::Call *op) override { | |||
| return common::DefaultDeviceTarget().arch.Match( | |||
ZhangX-21
approved these changes
Apr 14, 2025
phlrain
approved these changes
Apr 14, 2025
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
…lePaddle#72142) * remove hip call_get_value_in_kernel_args * fix hip reduce * remove cinn_get_value_in_hip_kernel fix bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Deprecations
Description
清理Hip Reduce模版函数，并简化Reduce模版函数命名