[CINN]Add iter_vals type cast logic #72204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
ggggxm
force-pushed
the
FixTypeMismatch
branch
3 times, most recently
from
f5868ac to
62af95c
Compare
ggggxm
changed the title
lshpku
reviewed
Apr 18, 2025
paddle/cinn/common/axis.cc
Outdated
| @@ -68,7 +68,7 @@ std::string axis_name(int level) { | |||
| std::vector<ir::Var> GenDefaultAxis(int naxis) { | |||
| std::vector<ir::Var> axis; | |||
| for (int i = 0; i < naxis; i++) { | |||
| axis.emplace_back(cinn::common::axis_name(i)); | |||
| axis.emplace_back(cinn::common::axis_name(i), type_of<int64_t>()); | |||
There was a problem hiding this comment.
这样改越界了，动到CINN的大动脉了，在这里改type对CINN影响太广，整个CINN流程里面的axis type都会变，没有详细评估不能这么改，照理来说应该只改tril算子自己的部分
ggggxm
changed the title
ggggxm
changed the title
lshpku
approved these changes
Apr 22, 2025
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Bug fixes
Description
_For_::Make)