Skip to content

[Dy2St] Cleanup legacy OpMaker based run program op #72351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

SigureMo
Copy link
Member

PR Category

Execute Infrastructure

PR Types

Deprecations

Description

清理基于 OpMaker 的 run program op,只保留动态图的 run program op(就算动态图还有新老 IR 两套 run program op 呢……老 IR 的目前还删不掉)

@SigureMo SigureMo requested a review from Copilot April 17, 2025 14:05
Copy link

paddle-bot bot commented Apr 17, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • paddle/fluid/operators/CMakeLists.txt: Language not supported
  • paddle/fluid/operators/unity_build_rule.cmake: Language not supported
  • paddle/fluid/pybind/CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (1)

paddle/fluid/operators/run_program_op.cc:1

  • Verify that the removal of the legacy RunProgramOp does not inadvertently affect any dynamic graph functionality or leave behind orphaned test cases that expect this legacy behavior.
Entire file removal

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maker是解析老静态图Program的“知识”,如果删掉Maker,develop将不在能load老的Program。这个是不是跟红雨问问?尤其是推理的一些老的业务会不会用到?

Copy link

paddle-ci-bot bot commented May 1, 2025

Sorry to inform you that 6c4ffb2's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants