Skip to content

[Fix] fix recompute to save random and numpy status #72364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2025

Conversation

zhangyuqin1998
Copy link
Contributor

@zhangyuqin1998 zhangyuqin1998 commented Apr 18, 2025

PR Category

Distributed Strategy

PR Types

Bug fixes

Description

fix recompute to save random and numpy status

Pcard-76459

Copy link

paddle-bot bot commented Apr 18, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@181e2e3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...le/distributed/fleet/recompute/recompute_hybrid.py 50.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (88.23%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #72364   +/-   ##
==========================================
  Coverage           ?   61.39%           
==========================================
  Files              ?        2           
  Lines              ?      443           
  Branches           ?        0           
==========================================
  Hits               ?      272           
  Misses             ?      171           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ForFishes ForFishes merged commit f4ae4d3 into PaddlePaddle:develop Apr 19, 2025
43 of 45 checks passed
YqGe585 pushed a commit to YqGe585/Paddle that referenced this pull request May 7, 2025
* [Fix] fix recompute to save random and numpy status

* fix code style
@zhangyuqin1998 zhangyuqin1998 deleted the develop_fix_recompute branch May 9, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants