[SOT] Support recursive fallback in psdb and add ut for psdb #72381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
requested review from
Copilot
and removed request for
zrr1999 and
gouzil
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the fallback behavior in psdb by adding a recursive parameter and updates the associated unit tests and opcode translator error handling.
- Added unit tests in test/sot/test_psdb.py to verify both recursive and non-recursive fallback behaviors.
- Updated psdb.fallback in python/paddle/jit/sot/psdb.py to accept a recursive parameter.
- Modified the opcode translator in python/paddle/jit/sot/opcode_translator/executor/variables/callable.py to include the recursive parameter in fallback error messages.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/sot/test_psdb.py | Added tests covering various fallback scenarios and breakgraph behaviors. |
| python/paddle/jit/sot/psdb.py | Revised fallback function signature to include a recursive parameter. |
| python/paddle/jit/sot/opcode_translator/executor/variables/callable.py | Updated fallback handling to extract and report the recursive parameter value. |
gouzil
approved these changes
Apr 22, 2025
SigureMo
deleted the
sot/support-recursive-fallback-in-psdb-and-add-ut-for-psdb
branch
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Devs
Description
psdb.fallback支持recursive参数，以确保递归 fallback，同时添加相关单测