[XPU] fix index's datatype, using int64 instead of int, part 1 (a-f) #72431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
cqulilujia
commented
Apr 24, 2025
| @@ -46,5 +46,31 @@ inline void ExtractNCWHD(const phi::DDim &dims, | |||
| : 1; | |||
| } | |||
| } | |||
|
|
|||
| inline void ExtractNCWHD(const phi::DDim &dims, | |||
cqulilujia
commented
Apr 24, 2025
| @@ -61,7 +61,7 @@ void GatherGradKernel(const Context& dev_ctx, | |||
| dev_ctx.template Alloc<T>(x_grad); | |||
| using XPUType = typename XPUTypeTrait<T>::Type; | |||
|
|
|||
| int r = XPU_SUCCESS; | |||
| int r = 0; | |||
There was a problem hiding this comment.
算子返回值写法后续会统一清理和统一，这里先顺手改掉
|
LGTM |
raindrops2sea
approved these changes
Apr 24, 2025
houj04
approved these changes
May 6, 2025
Enigmatisms
pushed a commit
to Enigmatisms/Paddle
that referenced
this pull request
May 7, 2025
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Custom Device
PR Types
Bug fixes
Description
Use int64 datatype for index instead of int in kernels , part 1 (a-f)