-
Notifications
You must be signed in to change notification settings - Fork 5.7k
【快乐开源】Paddle Tensor 规范化二期 test_inv&test_linalg_matmul #72574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
mayiru1021 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
1 similar comment
mayiru1021 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
抱歉回复的比较晚,0-size和复数类型支持是paddle Tensor规范化项目的目的之一,所以如果遇到这类问题,可以尝试对涉及到的算子进行支持和完善,另外你的报错看起来是where没支持复数,在 #72247 中进行了支持,你可以尝试使用develop版的paddle重新运行试试 |
需要签署下CLA |
感谢回复,test_linalg.py::test_inv已经可以通过单测 |
好的,已经签署了 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感谢提交PR,还麻烦增加两个对应的单测,分别测试 0-size 的inv和matmul
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文件跟本PR有关系吗?
// PADDLE_ENFORCE_NOT_NULL( | ||
// x_data, errors::InvalidArgument("The input X should not be empty.")); | ||
// PADDLE_ENFORCE_NOT_NULL( | ||
// y_data, errors::InvalidArgument("The input Y should not be empty.")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的注释,可以直接删掉吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mayiru1021 test_inv可以通过的话,可以单独提一个PR先把修复test_inv的部分,给合入 |
PR Category
【快乐开源】Paddle Tensor 规范化二期 0-size test_inv&test_linalg_matmul两个单测
PR Types
修复test_inv&test_linalg_matmul的0-size输入情况
Description
目前 test_inv可以通过单测,但存在生成两类输入时由于涉及到的算子不支持复数或0-size导致输入生成失败的问题