[XPU] UpdatePadding has already modified the value of pad #72618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
HarperCy
reviewed
May 8, 2025
| paddings[1] += (in_h_ceil - in_h); | ||
| paddings[3] += (in_w_ceil - in_w); | ||
| } | ||
|
|
There was a problem hiding this comment.
UpdatePadding已经更新了padding，这个计算反而导致结果出错，目前修复后，结果已经和CUDA对齐
There was a problem hiding this comment.
这里删掉了一些代码，没有修改单测，流水线为什么是可以通过的呢？是原先有漏测么？
QingshuChen
approved these changes
May 8, 2025
This was referenced May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
The UpdatePadding function has been designed to adjust the padding appropriately, regardless of whether ceil_mode is set to True or False in the Pool2D operation, however, the additional code that attempts to adjust the padding can lead to error, so remove this redundant part of the code.