[XPU] add complex,real,imag,conj op for xpu
#72649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
fangfangssj
changed the title
complex,real,imag op for xpucomplex,real,imag op for xpu
dynamicheart
approved these changes
May 13, 2025
| dev_ctx.template Alloc<T>(dx, static_cast<size_t>(numel * sizeof(T))); | ||
| DenseTensor real = Fill<phi::dtype::Real<T>, Context>( | ||
| dev_ctx, common::vectorize<int>(dout.dims()), phi::dtype::Real<T>(0.0)); | ||
| int r = xfft_internal::xpu::combine_as_complex( |
houj04
reviewed
May 13, 2025
houj04
reviewed
May 13, 2025
|
|
||
| #include "paddle/phi/kernels/complex_grad_kernel.h" | ||
|
|
||
| #include "fft/cuComplex.h" |
There was a problem hiding this comment.
这里是不是需要开启WITH_XPU_XFT才能编译？那就要考虑以下几件事：
1、现在这个配置，默认是OFF，所以默认情况下就编不过？
2、是否需要像其它宏定义一样，加个判断？比如，如果没定义这个，就走到另外的分支上，报not implemented或者precondition not met。
There was a problem hiding this comment.
是的，已修改为打开WITH_XPU_FFT才编译新增加的fft相关的算子，未打开的情况上不编译进去
这样的话不需要报not implemented或者precondition not met，当未编译时使用到相关的算子时，框架会自动fallback回cpu上执行，这样不会报错，使用体验更好一些
| reinterpret_cast<cuFloatComplex*>(const_cast<T*>(x.data<T>())), | ||
| reinterpret_cast<cuFloatComplex*>(out->data<T>())); | ||
| PADDLE_ENFORCE_XDNN_SUCCESS(r, "conj"); | ||
| if (std::is_same<T, phi::dtype::complex<float>>::value) { |
There was a problem hiding this comment.
可以尝试把is_same::value换成is_same_v
There was a problem hiding this comment.
在下个PR中修改，同时conj在xpu3_op_list.cc中少添加的类型也在下个PR中添加
fangfangssj
changed the title
complex,real,imag op for xpucomplex,real,imag,conj op for xpu
zyfncg
approved these changes
May 15, 2025
|
/re-run approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator Mechanism
PR Types
New features
Description
XPU新增
complex,real,imag,conj四个算子和对应单测Pcard-75624