[SOT][Exception] Fix zerodiv not raising #73030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
DrRyanHuang
commented
May 30, 2025
test/sot/test_24_exceptions.py
Outdated
| self.assert_results(foo_mod, 10) | ||
| self.assert_exceptions( | ||
| ZeroDivisionError, | ||
| "integer (.)* modulo by zero", |
There was a problem hiding this comment.
3.9和3.10 报错：
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ZeroDivisionError: integer division or modulo by zero3.11 到 3.13 报错:
File "<python-input-0>", line 1, in <module>
3 % 0
~~^~~
ZeroDivisionError: integer modulo by zero但是3.14报错：
Traceback (most recent call last):
File "<python-input-1>", line 1, in <module>
3 % 0
~~^~~
ZeroDivisionError: division by zeroTODO: 之后适配 3.14 要注意下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
执行
fn:先执行
x=1，之后执行x=0，并不会报错这个PR将除数是否为0添加到 guard 中
PCard-66972
之前PR #72784 (comment) 的遗留问题