[AutoParallel] support tp_conv #73039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
danleifeng
reviewed
Jun 4, 2025
| ) | ||
|
|
||
|
|
||
| def _ring_send_recv_construct( |
| grad_weight = dist.auto_parallel.api.dtensor_from_local( | ||
| grad_weight, weight_mesh, weight_placements | ||
| ) | ||
| grad_weight = dist.reshard( |
| grad_bias = dist.auto_parallel.api.dtensor_from_local( | ||
| grad_bias, bias_mesh, bias_placements | ||
| ) | ||
| grad_weight = dist.reshard( |
| in_dygraph_mode() | ||
| and x.is_dist() | ||
| and self._data_format in ["NCHW", "NHWC"] | ||
| ): |
There was a problem hiding this comment.
if分支这里可以加下注释，走RingConv2d的条件
| return reconstructed_tensor | ||
|
|
||
|
|
||
| def _ring_send_recv_aggregate( |
There was a problem hiding this comment.
统一在中层 api 的 pr 里面修改
zhiqiu
previously approved these changes
Jun 5, 2025
zyfncg
reviewed
Jun 5, 2025
| ) | ||
| and "conv2d" not in forward_api_contents[op_string] |
There was a problem hiding this comment.
已经设置了几处黑名单了，为什么还要加conv2d的特判？
There was a problem hiding this comment.
已经设置了几处黑名单了，为什么还要加conv2d的特判？
因为上面给 conv2d 的黑名单移除了, conv2d 的 py api 应该是有其他地方处理了，我之前不加这个特判的时候 windows 和 mac 版本的 paddle 会编译报错 提示 conv2d 重复定义（linux 下编译没问题）
zyfncg
approved these changes
Jun 5, 2025
|
/re-run all-failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Auto Parallel
PR Types
New features
Description
为自动并行支持 tp conv
当前的 TP Conv 实现基于 Ring 通信机制，在 W 维上对输入进行切分，并通过 halo 区域的数据交换实现边界感受野覆盖。前向阶段采用 ring-send-recv 构造 halo，后向阶段在本地梯度聚合后同样通过 ring 通信完成交叉更新。当前版本仅支持 dilation=1，支持典型的 stride=1 卷积和部分等间隔下采样卷积
Pcard-76459