Bazel protobuf and gtest #818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…github.com/google/protobuf/ as external dependency for protobuf
|
Following discussions in #819 (review), I changed WORKSPACE to use Google protobuf as the external dependency for protobuf. @reyoung @lipeng-unisound Please review. |
reyoung
approved these changes
Dec 12, 2016
| # rules. This method comes from | ||
| # https://github.com/pubref/rules_protobuf#usage. | ||
| git_repository( | ||
| name = "org_pubref_rules_protobuf", |
|
The whole plan about bazel build, see #792. @wangkuiyi We could edit the issue for every updates. |
|
@reyoung Good point. To keep each PR a reasonablly small size, I splitted the work "incorporate glog, gtest, gflags, protobuf" listed in #792 into two:
This PR fixes #816 . Since it incorporate gtest, someone else working on a PR fixing #822 can use gtest. |
| .. code-block:: bash | ||
|
|
||
| docker run \ | ||
| -d # run the container in background mode \ |
There was a problem hiding this comment.
The backslash continues the comments to next lines, thus makes the docker run command wrong.
zhhsplendid
pushed a commit
to zhhsplendid/Paddle
that referenced
this pull request
Sep 25, 2019
wangxicoding
pushed a commit
to wangxicoding/Paddle
that referenced
this pull request
Dec 9, 2021
fix waybill data_dir; remove data files
wwbitejotunn
pushed a commit
to wwbitejotunn/Paddle
that referenced
this pull request
Jun 21, 2024
tianyuzhou668
pushed a commit
to tianyuzhou668/Paddle
that referenced
this pull request
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #816
In this PR,
I initialize Bazel WORKSPACE file to declare an external dependency to https://github.com/pubref/rules_protobuf, which implements the Google-style protobuf building rules.
For more information please refer to this example repo: https://github.com/wangkuiyi/learn-bazel.
I also add a simple package in
/third_party/protobuf_testto demonstrate using protobuf and gtest.I updated the
docker_install_en.rstdocuments to show how we can develop using Docker and Bazel.Dear reviewers:
Please feel free to use Docker and Bazel to check this PR as described in my update to Docker document in this PR.