Skip to content

Fix the grammar in copyright. #8403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2018
Merged

Fix the grammar in copyright. #8403

merged 1 commit into from
Feb 12, 2018

Conversation

qingqing01
Copy link
Contributor

@qingqing01 qingqing01 commented Feb 12, 2018 •
edited
Loading

All Rights Reserve -> All Rights Reserved

dzhwinter
dzhwinter previously approved these changes Feb 12, 2018
View reviewed changes
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
By the way, our copyright hook has been fixed in previous PR.

typhoonzero
typhoonzero previously approved these changes Feb 12, 2018
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the .copyright-hook is updated I see.

@qingqing01 qingqing01 dismissed stale reviews from typhoonzero and dzhwinter via fe8e1c7 February 12, 2018 08:38
dzhwinter
dzhwinter approved these changes Feb 12, 2018
View reviewed changes
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzhwinter dzhwinter merged commit 24509f4 into PaddlePaddle:develop Feb 12, 2018
@chengduoZH chengduoZH mentioned this pull request May 15, 2018
Closed
@qingqing01 qingqing01 deleted the copyright branch November 14, 2019 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzhwinter dzhwinter dzhwinter approved these changes

@typhoonzero typhoonzero typhoonzero left review comments

@reyoung reyoung Awaiting requested review from reyoung

@wangkuiyi wangkuiyi Awaiting requested review from wangkuiyi

@pkuyym pkuyym Awaiting requested review from pkuyym

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qingqing01 @dzhwinter @typhoonzero