Fix Travis-CI build error. #858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* error because merge of PaddlePaddle#711. The old issue don't check pre-commit hooks.
wangkuiyi
reviewed
Dec 13, 2016
| except AssertionError as e: | ||
| self.logger.error( | ||
| def __call__(self, obj, filename): | ||
| for items in self.generator(obj, filename): |
There was a problem hiding this comment.
Python初学者好奇：这个PR修复的问题是由错误的indentation导致的呀？
There was a problem hiding this comment.
是因为目前Paddle在持续集成的Travis-CI上面检查了代码风格。原理是直接用yapf format python code，用clang-format格式化cpp code，如果有diff，那么就直接CI报错。
由于这个检查是最近一些PR加进去的，之前的PR并没有强制的跑这个检查。所以出错了。
解决办法就是直接重新format一遍就好了。命令是pre-commit run -a
hedaoyuan
approved these changes
Dec 13, 2016
wangxicoding
pushed a commit
to wangxicoding/Paddle
that referenced
this pull request
Dec 9, 2021
[Feat] Add custom op for FasterTransformer decoder
yaozhixin
pushed a commit
to graphcore/Paddle-fork
that referenced
this pull request
Jul 1, 2022
…-ipu_8845a1cf6a51b4fc3c80641ce03e049d3aadc487 [AUTO PR] Pulling [develop] into [develop-ipu] [2022-07-01 03:05:17+08:00]
lizexu123
pushed a commit
to lizexu123/Paddle
that referenced
this pull request
Feb 23, 2024
zhangyuqin1998
pushed a commit
to zhangyuqin1998/Paddle
that referenced
this pull request
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hooks.