Skip to content

fix nan in ppocrv4 for benchmark #14072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

wangna11BD
Copy link
Contributor

fix nan in ppocrv4 for benchmark

@GreatV
Copy link
Collaborator

GreatV commented Oct 23, 2024

ppocrv3能跑吗

Copy link
Collaborator

@GreatV GreatV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么要额外加一个配置参数

@wangna11BD
Copy link
Contributor Author

为什么要额外加一个配置参数

大部分模型没有出现训练出nan,对这些模型,加了这2行过滤nan后没有实际作用,训练速度会下降,显存也会升高,所以额外加一个参数,给有需要的模型在配置文件里加。

@wangna11BD
Copy link
Contributor Author

ppocrv3能跑吗

QA给的反馈是只有ppocrv4出现了训练出nan,其他模型还没有问题。

@wangna11BD
Copy link
Contributor Author

@GreatV

Copy link
Collaborator

@GreatV GreatV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GreatV GreatV merged commit 661cda1 into PaddlePaddle:main Oct 23, 2024
3 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants