Skip to content

【PPSCI Doc No.23、25-29、31-34、97】 #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 12, 2024

Conversation

1want2sleep
Copy link
Contributor

@1want2sleep 1want2sleep commented Apr 9, 2024

PR types

Others

PR changes

Docs

Describe

补全 #686 中的23、25-29、31-34、97 api的文档
其中,第32 ppsci.autodiff.Jacobians.call 没看出来有问题。
97 代码示例单独测试没问题 doctest有问题

Copy link

paddle-bot bot commented Apr 9, 2024

Thanks for your contribution!

@1want2sleep 1want2sleep changed the title 【PPSCI Doc No.23、25-29、31-34】 【PPSCI Doc No.23、25-29、31-34、97】 Apr 10, 2024
@@ -413,7 +413,12 @@ class AFNONet(base.Arch):

Examples:
>>> import ppsci
>>> model = ppsci.arch.AFNONet(("input", ), ("output", ))
>>> model = ppsci.arch.AFNONet(("input", ), ("output", ), img_size=(180, 360))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议img_size修改为常用大小 720,1440

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢提交PR,分布式的测试可以加上跳过代码,顺便合一下最新develop分支

>>> import paddle
>>> import ppsci
>>> import paddle.distributed as dist
>>> dist.init_parallel_env()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

末尾加上: # doctest: +SKIP

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Done.

>>> import ppsci
>>> import paddle.distributed as dist
>>> dist.init_parallel_env()
>>> if dist.get_rank() == 0:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

末尾加上 # doctest: +SKIP

... data = paddle.to_tensor([[1, 2, 3], [4, 5, 6]])
... else:
... data = paddle.to_tensor([[7, 8, 9], [10, 11, 12]])
>>> result = ppsci.utils.misc.all_gather(data)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

末尾加上 # doctest: +SKIP

... else:
... data = paddle.to_tensor([[7, 8, 9], [10, 11, 12]])
>>> result = ppsci.utils.misc.all_gather(data)
>>> print(result.numpy())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

末尾加上 # doctest: +SKIP

Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HydrogenSulfate HydrogenSulfate merged commit 2fd294c into PaddlePaddle:develop Apr 12, 2024
2 of 4 checks passed
huohuohuohuohuo123 pushed a commit to huohuohuohuohuo123/PaddleScience that referenced this pull request Aug 12, 2024
* ppsci.equation.PDE.parameters/state_dict/set_state_dict api fix

* ppsci.equation.PDE.parameters/state_dict/set_state_dict api fix

* fix api docs in the timedomain

* fix api docs of timedomain

* fix api docs of timedomain

* ppsci api docs fixed

* ppsci api docs fixed

* ppsci api docs fixed

---------

Co-authored-by: krp <2934631798@qq.com>
Co-authored-by: HydrogenSulfate <490868991@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants