Update kernel migrate doc #5257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢你贡献飞桨文档，文档预览构建中，Docs-New 跑完后即可预览，预览链接：http://preview-pr-5257.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html |
chenwhql
reviewed
Sep 7, 2022
docs/design/phi/kernel_migrate_cn.md
Outdated
| ... 其他参数省略, | ||
| DenseTensor* out) { | ||
|
|
||
| if (std::is_same<T, uint8_t>::value) { |
There was a problem hiding this comment.
这里是不是直接用PD_VISIT，或者switch case好一些，万一有啥扩展，else可能就不是float了，宁愿switch case到最后default PADDLE_THROW也更安全一些
chenwhql
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
更新异构设备kernel迁移文档