Improve ACL implementation #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteymix
force-pushed
the
wip/improve-acl-dao
branch
4 times, most recently
from
e416e6f to
e9cf135
Compare
Take advantage of eager fetching and second-level cache for ACLs Avoid querying the database in AclDao, models are already eagerly fetched, so querying is pointless. Remove ACL cache, ACLs are already stored in the second-level cache. Use Spring-supplied ACL implementation
|
It's pretty much completed now. I need to do more testing with Gemma before merging. |
arteymix
force-pushed
the
wip/improve-acl-dao
branch
from
e9cf135 to
f3f16a0
Compare
|
The natural ID for object identity should be marked as immutable. We can also enable cache for natural IDs albeit there is no XML support for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take advantage of eager fetching and second-level cache for ACLs
Avoid querying the database in AclDao, models are already eagerly fetched, so querying is pointless.
Remove ACL cache, ACLs are already stored in the second-level cache.
Use Spring-supplied ACL implementation