embed.fnc: Need p flag for non-static public elements #23487
Conversation
If a function or macro 'foo' is publicly accessible, there should be a 'Perl_foo' form available for callers to use so as to avoid any name collisions with their own names. Now that we can automatically generate Perl_foo equivalents for macros, make sure that the flags indicate that. I first thought to add the p flag automatically, but that would require a bunch of restructuring. By requiring the flag, in embed.fnc, the true state of things doesn't get hidden.
| # define Perl_hv_stores(mTHX,a,b,c) hv_stores(a,b,c) | ||
| # define Perl_hv_undef(mTHX,a) hv_undef(a) | ||
| # define Perl_ibcmp(mTHX,a,b,c) ibcmp(a,b,c) | ||
| # define Perl_ibcmp_locale(mTHX,a,b,c) ibcmp_locale(a,b,c) | ||
| # define Perl_ibcmp_utf8(mTHX,a,b,c,d,e,f,g,h) ibcmp_utf8(a,b,c,d,e,f,g,h) | ||
| # define Perl_newATTRSUB(mTHX,a,b,c,d,e) newATTRSUB(a,b,c,d,e) |
There was a problem hiding this comment.
Can you explain what the mTHX is or means?
does it drop out on no-threads perls?
does it drop out on thread perls?
is it a dummy argument to capture and NOOP the end users aTHX_ token?
Does lets say this line
#define Perl_hv_stores(mTHX,a,b,c) hv_stores(a,b,c)
^^^^dropped out
And then later on
#define hv_stores(a,b,c) Perl_hv_storepvn(aTHX_ (a), (b), STRLENs(b), (c))
SO my example shows hv_stores() never used the callers aTHX_ macro arg and ignored it, and after expansion hv_stores(a,b,c) used it own silently made private instance of aTHX_ to execute the real C symbol Perl_hv_storepvn? is this right or am i making a mistake understanding this?
There was a problem hiding this comment.
mTHX is #ifdef'ed to be used only on threaded perls. It matches the aTHX parameter that it is known should be passed to the macro in this first position. It does nothing with that argument. Since this is a macro, embed.fnc knows that aTHX is available to it (based on the flags arg to its embed.fnc entry). The expansion could use aTHX directly, or the expansion could call a macro which just assumes aTHX is available. In either case, things just work.
If a function or macro 'foo' is publicly accessible, there should be a 'Perl_foo' form available for callers to use so as to avoid any name collisions with their own names.
Now that we can automatically generate Perl_foo equivalents for macros, make sure that the flags indicate that.
I first thought to add the p flag automatically, but that would require a bunch of restructuring. By requiring the flag, in embed.fnc, the true state of things doesn't get hidden.