Skip to content

Fix invalid string length error in JSON.stringify when handling big projects #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix invalid string length error in JSON.stringify when handling big projects #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions src/runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,19 +179,28 @@ define(function (require, exports) {
if (!filename.endsWith(".json")) {
filename += ".json";
}
fs.writeFile(filename, JSON.stringify(result, null, 2), function (err) {
if (err) {
/*
When happened something wrong (usually out of memory when we want print
the result into a file), then we try to file with JSONStream.
*/
let transformStream = JSONStream.stringify();
let outputStream = fs.createWriteStream(filename);
transformStream.pipe(outputStream);
result.forEach(transformStream.write);
transformStream.end();

var json_out = "";

fs.writeFileSync(filename, "[", { flag: 'w+' }); /* Write initial JSON header and create file */

for (var indx = 0; indx < result.length - 1; indx++) {
var current = JSON.stringify(result[indx], null, 2) + ",";

/* Most recent string length limit = 2^29 - 16
https://github.com/v8/v8/commit/ea56bf5513d0cbd2a35a9035c5c2996272b8b728 */
if (json_out.length >= 2 ** 29 - 16 - current.length) {
fs.writeFileSync(filename, json_out, { flag: 'a' });
json_out = "";
}
});

json_out += current;
}

fs.writeFileSync(filename, json_out, { flag: 'a' });

json_out = JSON.stringify(result[result.length - 1], null, 2) + "]";
fs.writeFileSync(filename, json_out, { flag: 'a' }); /* Write final JSON bytes */

}
return result;
Expand Down