Andres Burbano Frontend challenge #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teffcode
reviewed
Aug 19, 2020
There was a problem hiding this comment.
Amazing Job 🚀
Average:
- HTML: 65%
- CSS: 65%
- JS: 80%
Things we can improve:
- Remove lines of code that are not going to be used (Like iframe)
In addition:
- The requirement # 2 (characters in CSS) are not in the code. I only see images.
- The requirement # 6 (Giphy API) are not in the code. Review
promisesandfetchconcepts in JavaScript.
Conclusion:
- Your challenge solution is not complete. For this reason, HTML & CSS are 65% because # 2 requirement is missing, and JS is 80% because # 6 requirement is missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Muy buen reto.