Skip to content

Reto terminado Luis Gerardo #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Reto terminado Luis Gerardo #23

wants to merge 6 commits into from

Conversation

luisglopez7777
Copy link

No description provided.

teffcode
teffcode reviewed Aug 19, 2020
View reviewed changes
Copy link
Contributor

@teffcode teffcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing Job 🚀

Average:

  • HTML: 100%
  • CSS: 100%
  • JS: 100%

Things we can improve:

  • Indentation
  • Semantic HTML
  • Remove lines of code that are not going to be used
  • Have separate files for the HTML and the JS

@luisglopez7777
Copy link
Author

Thanks @teffcode ... Sure, my code is not as fancy. Going to focus on that!

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teffcode teffcode teffcode left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luisglopez7777 @teffcode