Use proper cmake exports #5958
Use proper cmake exports #5958
Conversation
larshg
force-pushed
the
Usepropercmakeexport
branch
2 times, most recently
from
47db731 to
55ce06a
Compare
|
Might be a candidate for a test build in vcpkg ... once the other port issues are sorted out. |
larshg
force-pushed
the
Usepropercmakeexport
branch
2 times, most recently
from
d640a97 to
03925ea
Compare
| DISSECT_VERSION() | ||
| GET_OS_INFO() | ||
| SET_INSTALL_DIRS() |
There was a problem hiding this comment.
I would appreciate adopting lower-case commands in new/moved CMake code.
There was a problem hiding this comment.
I don't mind, do you have any pointers that this is "good practice or examples where this is done" 👍
There was a problem hiding this comment.
Just glanced at methods at VTK - and indeed they are seemingly all lowercase - I'll keep it in mind.
There was a problem hiding this comment.
Basically it is done in all modern CMake code, including reference documentation. I believe lower-case is widely accepted as more readable for humans.
The transition is facilitated by the fact that command names are case-insensitive.
(Variable names are case-sensitive, and I don't have a strong opinion about them. Also keywords like PUBLIC are case-sensitive. This makes them stand out nicely. Don't discussion build types 🤦)
There was a problem hiding this comment.
Just glanced at methods at VTK - and indeed they are seemingly all lowercase - I'll keep it in mind.
VTK... It is maintained by Kitware as is CMake. It is probably an old CMake code base, and it tells me that Kitware should ... have a lot of early awareness of shortcomings in CMake.
(Coincidentally I'm trying to fix issues in the vtk port in vcpkg.)
Yes, this is on the todo - but would probably be a separate PR as it require lot of changes. |
larshg
force-pushed
the
Usepropercmakeexport
branch
2 times, most recently
from
9f43486 to
9310a16
Compare
…calls. add AVX compile options to libraries. Add alias naming with namespace prefix. Add export of PCLTargets.
larshg
force-pushed
the
Usepropercmakeexport
branch
3 times, most recently
from
755f27d to
9aa44fa
Compare
larshg
force-pushed
the
Usepropercmakeexport
branch
from
9aa44fa to
4084e25
Compare
2 participants
No description provided.