Skip to content

Conversation

mvieth
Copy link
Member

@mvieth mvieth commented Oct 5, 2025

Follow-up of #6347

@mvieth mvieth force-pushed the nanoflann_default3 branch 6 times, most recently from e96661e to 6608fe5 Compare October 5, 2025 12:32
@mvieth mvieth force-pushed the nanoflann_default3 branch from 6608fe5 to b72cce3 Compare October 12, 2025 09:02
@mvieth mvieth force-pushed the nanoflann_default3 branch from b72cce3 to 0e8a68c Compare October 12, 2025 09:05
@mvieth mvieth added changelog: enhancement Meta-information for changelog generation module: search labels Oct 12, 2025
@mvieth mvieth requested a review from Copilot October 12, 2025 09:07
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR continues the migration from deprecated KdTreeFLANN and pcl::search::KdTree to the modern pcl::search::autoSelectMethod API, following up on PR #6347. The changes improve search method selection by automatically choosing the optimal search implementation based on cloud characteristics.

Key changes:

  • Replace manual KdTree instantiation with autoSelectMethod calls across multiple modules
  • Update function signatures to use generic Search interface instead of KdTree-specific types
  • Add missing header includes for files that now depend on the auto-selection functionality

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tools/mls_smoothing.cpp Remove unused KdTree setup and include
tools/gp3_surface.cpp Remove manual KdTree instantiation
tools/fpfh_estimation.cpp Remove manual KdTree setup and include
tools/compute_cloud_error.cpp Replace KdTreeFLANN with autoSelectMethod
surface/include/pcl/surface/*.h Remove deprecated KdTree type aliases
surface/include/pcl/surface/impl/*.hpp Replace manual tree selection with autoSelectMethod
segmentation/include/pcl/segmentation/impl/*.hpp Modernize search method initialization
search/include/pcl/search/auto.* Add overload supporting indices parameter
registration files Update to use generic Search interface
test files Add required kdtree.h includes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mvieth mvieth marked this pull request as ready for review October 12, 2025 09:12
@larshg larshg merged commit e5ce18f into PointCloudLibrary:master Oct 12, 2025
13 checks passed
@mvieth mvieth deleted the nanoflann_default3 branch October 12, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: enhancement Meta-information for changelog generation module: search

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants