2021, 2022, 2024 State Sales Tax #5591
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5591 +/- ##
==========================================
- Coverage 99.10% 99.07% -0.03%
==========================================
Files 2687 2695 +8
Lines 38934 38988 +54
Branches 170 171 +1
==========================================
+ Hits 38585 38629 +44
- Misses 315 326 +11
+ Partials 34 33 -1 ☔ View full report in Codecov by Sentry. |
|
Lets add a changelog entry and and test for 2021 |
PavelMakarchuk
approved these changes
Feb 18, 2025
MaxGhenis
requested changes
Feb 18, 2025
There was a problem hiding this comment.
also please:
- fix the metadata for income_bracket.yaml
- cite other years' sources in all three yaml files
- try to find statutory or regulatory backing for this program; if not available, note that in a comment
- add the script you used to generate the yaml content
There was a problem hiding this comment.
add references for other years
MaxGhenis
reviewed
Feb 20, 2025
| @@ -8,6 +8,32 @@ metadata: | |||
| href: https://www.irs.gov/instructions/i1040sca#en_US_2024_publink1000131499 | |||
|
|
|||
| values: | |||
| 2021-01-01: | |||
There was a problem hiding this comment.
don't need new yearly entries if it hasn't changed
|
just checking in on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5589