Puerto Rico Refundable CTC - form 1040 computation #5925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
llennemann
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5925 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 2817 2819 +2
Lines 40742 40766 +24
Branches 190 190
=======================================
+ Hits 40379 40403 +24
Misses 328 328
Partials 35 35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hua7450
suggested changes
Apr 30, 2025
hua7450
approved these changes
May 8, 2025
PavelMakarchuk
requested changes
May 9, 2025
...ngine_us/variables/gov/territories/pr/tax/income/credits/refundable_ctc/pr_refundable_ctc.py
Outdated
Show resolved
Hide resolved
...ov/territories/pr/tax/income/credits/refundable_ctc/pr_refundable_ctc_social_security_tax.py
Outdated
Show resolved
Hide resolved
| # This provision is part of the federal CTC legal code | ||
| # will will merge the logic with the federal CTC once the puerto income tax structure is completed | ||
| def formula(tax_unit, period, parameters): | ||
| # line 24 |
There was a problem hiding this comment.
Could you add the tax form to the reference section in all variables where we use the line comments?
PavelMakarchuk
requested changes
May 27, 2025
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| class pr_gross_income(Variable): | |||
There was a problem hiding this comment.
Suggested change
| class pr_gross_income(Variable): | |
| class pr_gross_income_person(Variable): |
There was a problem hiding this comment.
assuming that we will need a taxunit level gross income concept down the line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5923