Fix tests to not emit unused stderr output

dsc/tests/dsc_discovery.tests.ps1

@@ -95,7 +95,6 @@ Describe 'tests for resource discovery' {
             $env:DSC_RESOURCE_PATH = $testdrive
             Set-Content -Path "$testdrive/test.dsc.resource.json" -Value $manifest
             $out = dsc resource list 2>&1
-            write-verbose -verbose ($out | Out-String)
             $out | Should -Match 'WARN.*?Validation.*?invalid version' -Because ($out | Out-String)
         }
         finally {
@@ -166,21 +165,18 @@ Describe 'tests for resource discovery' {
         $env:PSModulePath = $oldPSModulePath
     }
 
-    It 'Verify non-zero exit code when resource not found' {
+    It 'Verify non-zero exit code when resource not found: <cmdline>' -TestCases @(
+        @{ cmdline = "dsc resource get -r abc/def" }
+        @{ cmdline = "dsc resource get --all -r abc/def" }
+        @{ cmdline = "dsc resource set -r abc/def -i 'abc'" }
+        @{ cmdline = "dsc resource test -r abc/def -i 'abc'" }
+        @{ cmdline = "dsc resource delete -r abc/def -i 'abc'" }
+        @{ cmdline = "dsc resource export -r abc/def" }
+        @{ cmdline = "dsc resource schema -r abc/def" }
+    ) {
+        param($cmdline)
 
-        $out = dsc resource get -r abc/def
-        $LASTEXITCODE | Should -Be 7
-        $out = dsc resource get --all -r abc/def
-        $LASTEXITCODE | Should -Be 7
-        $out = 'abc' | dsc resource set -r abc/def -f -
-        $LASTEXITCODE | Should -Be 7
-        $out = 'abc' | dsc resource test -r abc/def -f -
-        $LASTEXITCODE | Should -Be 7
-        $out = 'abc' | dsc resource delete -r abc/def -f -
-        $LASTEXITCODE | Should -Be 7
-        $out = dsc resource export -r abc/def
-        $LASTEXITCODE | Should -Be 7
-        $out = dsc resource schema -r abc/def
+        Invoke-Expression $cmdline 2>$null
         $LASTEXITCODE | Should -Be 7
     }
 

dsc/tests/dsc_extension_discover.tests.ps1

@@ -108,7 +108,6 @@ Describe 'Discover extension tests' {
             $out.Count | Should -Be 1 -Because ($out | Out-String)
             $out.type | Should -Be 'Test/DiscoverRelative'
             $out = dsc resource list 2> $TestDrive/error.log
-            write-verbose -verbose (Get-Content -Path "$TestDrive/error.log" -Raw)
             $LASTEXITCODE | Should -Be 0
             $out | Should -BeNullOrEmpty
             $errorMessage = Get-Content -Path "$TestDrive/error.log" -Raw

dsc/tests/dsc_include.tests.ps1

@@ -35,7 +35,7 @@ Describe 'Include tests' {
 "@
         $configPath = Join-Path $TestDrive 'config.dsc.yaml'
         $config | Set-Content -Path $configPath
-        dsc config get -f $configPath
+        dsc config get -f $configPath 2>$null
         $LASTEXITCODE | Should -Be 2
     }
 

dsc/tests/dsc_securitycontext.tests.ps1

@@ -13,7 +13,7 @@ Describe 'Tests for configuration security context metadata' {
     }
 
     It 'Require admin' {
-        $out = dsc config get -f $PSScriptRoot/../examples/require_admin.yaml
+        $out = dsc config get -f $PSScriptRoot/../examples/require_admin.yaml 2>$null
         if ($isAdmin) {
             $LASTEXITCODE | Should -Be 0
             $out | Should -Not -BeNullOrEmpty
@@ -24,7 +24,7 @@ Describe 'Tests for configuration security context metadata' {
     }
 
     It 'Require non-admin' {
-        $out = dsc config get -f $PSScriptRoot/../examples/require_nonadmin.yaml
+        $out = dsc config get -f $PSScriptRoot/../examples/require_nonadmin.yaml 2>$null
         if ($isAdmin) {
             $LASTEXITCODE | Should -Be 2
         }

dsc/tests/dsc_set.tests.ps1

@@ -61,7 +61,7 @@ Describe 'resource set tests' {
                 "_exist": false
             }
 '@
-            $null = registry config set --input $json
+            $null = registry config set --input $json 2>$null
         }
     }
 
@@ -73,7 +73,7 @@ Describe 'resource set tests' {
                 "_exist": false
             }
 '@
-            $null = registry config set --input $json
+            $null = registry config set --input $json 2>$null
         }
     }
 

dsc/tests/dsc_test.tests.ps1

@@ -9,7 +9,7 @@ Describe 'resource test tests' {
             "valueName": "ProductName"
         }
 '@
-        $current = registry config get --input $json
+        $current = registry config get --input $json 2>$null
         $out = $current | dsc resource test -r Microsoft.Windows/Registry -f -
         $LASTEXITCODE | Should -Be 0
         $out = $out | ConvertFrom-Json

dsc/tests/dsc_variables.tests.ps1

@@ -22,7 +22,6 @@ resources:
     output: "[variables('myVariable')]"
 '@
     $out = dsc config get -i $configYaml | ConvertFrom-Json
-    Write-Verbose -Verbose $out
     $LASTEXITCODE | Should -Be 0
     $out.results[0].result.actualState.output | Should -Be 'bar'
   }
@@ -39,7 +38,6 @@ resources:
     output: "[variables('myVariable')]"
 '@
     $out = dsc config get -i $configYaml 2>&1 | Out-String
-    Write-Verbose -Verbose $out
     $LASTEXITCODE | Should -Be 2
     $out | Should -BeLike "*Variable 'myVariable' does not exist or has not been initialized yet*"
   }

powershell-adapter/psDscAdapter/powershell.resource.ps1

@@ -26,11 +26,6 @@ trap {
     Write-DscTrace -Operation Debug -Message ($_ | Format-List -Force | Out-String)
 }
 
-# Adding some debug info to STDERR
-'PSVersion=' + $PSVersionTable.PSVersion.ToString() | Write-DscTrace
-'PSPath=' + $PSHome | Write-DscTrace
-'PSModulePath=' + $env:PSModulePath | Write-DscTrace
-
 if ($Operation -eq 'ClearCache') {
     $cacheFilePath = if ($IsWindows) {
         # PS 6+ on Windows
@@ -44,11 +39,15 @@ if ($Operation -eq 'ClearCache') {
         }
     }
 
-    'Deleting cache file ' + $cacheFilePath | Write-DscTrace
     Remove-Item -Force -ea SilentlyContinue -Path $cacheFilePath
     exit 0
 }
 
+# Adding some debug info to STDERR
+'PSVersion=' + $PSVersionTable.PSVersion.ToString() | Write-DscTrace
+'PSPath=' + $PSHome | Write-DscTrace
+'PSModulePath=' + $env:PSModulePath | Write-DscTrace
+
 if ($PSVersionTable.PSVersion.Major -le 5) {
     # For Windows PowerShell, we want to remove any PowerShell 7 paths from PSModulePath
     $env:PSModulePath = ($env:PSModulePath -split ';' | Where-Object { $_ -notlike '*\powershell\*' }) -join ';'
@@ -87,7 +86,7 @@ switch ($Operation) {
 
         # cache was refreshed on script load
         foreach ($dscResource in $dscResourceCache) {
-        
+
             # https://learn.microsoft.com/dotnet/api/system.management.automation.dscresourceinfo
             $DscResourceInfo = $dscResource.DscResourceInfo
 
@@ -99,7 +98,7 @@ switch ($Operation) {
                 if ($DscResourceInfo.Capabilities) {
                     $capabilities = $DscResourceInfo.Capabilities
                 } elseif ($module.PrivateData.PSData.DscCapabilities) {
-                    
+
                     $capabilities = $module.PrivateData.PSData.DscCapabilities
                 } else {
                     $capabilities = @('get', 'set', 'test')
@@ -183,7 +182,7 @@ switch ($Operation) {
             }
             $result += $actualState
         }
-    
+
         # OUTPUT json to stderr for debug, and to stdout
         if ($Operation -eq 'Test') {
             $result = @{ result = $result; _inDesiredState = $inDesiredState } | ConvertTo-Json -Depth 10 -Compress
@@ -196,7 +195,7 @@ switch ($Operation) {
     }
     'Validate' {
         # VALIDATE not implemented
-        
+
         # OUTPUT
         @{ valid = $true } | ConvertTo-Json
     }

registry/tests/registry.config.get.tests.ps1

@@ -8,7 +8,7 @@ Describe 'Registry config get tests' {
             "keyPath": "HKLM\\Software\\Microsoft\\Windows\\CurrentVersion"
         }
 '@
-        $out = registry config get --input $json 
+        $out = registry config get --input $json 2>$null
         $LASTEXITCODE | Should -Be 0
         $result = $out | ConvertFrom-Json
         $result.keyPath | Should -Be 'HKLM\Software\Microsoft\Windows\CurrentVersion'
@@ -22,7 +22,7 @@ Describe 'Registry config get tests' {
             "valueName": "ProgramFilesPath"
         }
 '@
-        $out = registry config get --input $json
+        $out = registry config get --input $json 2>$null
         $LASTEXITCODE | Should -Be 0
         $result = $out | ConvertFrom-Json
         $result.keyPath | Should -Be 'HKLM\Software\Microsoft\Windows\CurrentVersion'

registry/tests/registry.config.set.tests.ps1

@@ -18,16 +18,16 @@ Describe 'registry config set tests' {
             }
         }
 '@
-        $out = registry config set --input $json
+        $out = registry config set --input $json 2>$null
         $LASTEXITCODE | Should -Be 0
         $out | Should -BeNullOrEmpty
-        $result = registry config get --input $json | ConvertFrom-Json
+        $result = registry config get --input $json 2>$null | ConvertFrom-Json
         $result.keyPath | Should -Be 'HKCU\1\2\3'
         $result.valueName | Should -Be 'Hello'
         $result.valueData.String | Should -Be 'World'
         ($result.psobject.properties | Measure-Object).Count | Should -Be 3
 
-        $out = registry config get --input $json
+        $out = registry config get --input $json 2>$null
         $LASTEXITCODE | Should -Be 0
         $result = $out | ConvertFrom-Json
         $result.keyPath | Should -Be 'HKCU\1\2\3'
@@ -82,7 +82,7 @@ Describe 'registry config set tests' {
               properties:
                 keyPath: 'HKCU\1'
                 valueName: Test
-                _exist: true            
+                _exist: true
 '@
 
         $out = dsc config set -i $configYaml | ConvertFrom-Json

registry/tests/registry.config.whatif.tests.ps1

@@ -16,15 +16,15 @@ Describe 'registry config whatif tests' {
             "keyPath": "HKCU\\1\\2\\3"
         }
 '@
-        registry config set -w --input $json | Write-Host
-        $get_before = registry config get --input $json
-        $result = registry config set -w --input $json | ConvertFrom-Json
+        $null = registry config set -w --input $json 2>$null
+        $get_before = registry config get --input $json 2>$null
+        $result = registry config set -w --input $json 2>$null | ConvertFrom-Json
         $LASTEXITCODE | Should -Be 0
         $result.keyPath | Should -Be 'HKCU\1\2\3'
         $result._metadata.whatIf[0] | Should -Match '.*1.*'
         $result._metadata.whatIf[1] | Should -Match '.*2.*'
         $result._metadata.whatIf[2] | Should -Match '.*3.*'
-        $get_after = registry config get --input $json
+        $get_after = registry config get --input $json 2>$null
         $get_before | Should -EQ $get_after
     }
 
@@ -38,7 +38,7 @@ Describe 'registry config whatif tests' {
             }
         }
 '@
-        $result = registry config set -w --input $json | ConvertFrom-Json
+        $result = registry config set -w --input $json 2>$null | ConvertFrom-Json
         $LASTEXITCODE | Should -Be 0
         $result.keyPath | Should -Be 'HKCU\1\2\3'
         $result.valueName | Should -Be 'Hello'
@@ -54,7 +54,7 @@ Describe 'registry config whatif tests' {
             "keyPath": "HKCU\\1\\2"
         }
 '@
-        registry config set --input $set_json
+        registry config set --input $set_json 2>$null
         $whatif_json = @'
             {
                 "keyPath": "HKCU\\1\\2",
@@ -64,7 +64,7 @@ Describe 'registry config whatif tests' {
                 }
             }
 '@
-        $result = registry config set -w --input $whatif_json | ConvertFrom-Json
+        $result = registry config set -w --input $whatif_json 2>$null | ConvertFrom-Json
         $LASTEXITCODE | Should -Be 0
         $result.keyPath | Should -Be 'HKCU\1\2'
         $result.valueName | Should -Be 'Hello'
@@ -82,7 +82,7 @@ Describe 'registry config whatif tests' {
             }
         }
 '@
-        registry config set --input $set_json
+        registry config set --input $set_json 2>$null
         $whatif_json = @'
         {
             "keyPath": "HKCU\\1\\2\\3",
@@ -92,7 +92,7 @@ Describe 'registry config whatif tests' {
             }
         }
 '@
-        $result = registry config set -w --input $whatif_json | ConvertFrom-Json
+        $result = registry config set -w --input $whatif_json 2>$null | ConvertFrom-Json
         $LASTEXITCODE | Should -Be 0
         $result.keyPath | Should -Be 'HKCU\1\2\3'
         $result.valueName | Should -Be 'Hello'
@@ -110,7 +110,7 @@ Describe 'registry config whatif tests' {
             }
         }
 '@
-        registry config set --input $set_json
+        registry config set --input $set_json 2>$null
         $set_json = @'
         {
             "keyPath": "HKCU\\1\\2\\3",
@@ -120,13 +120,13 @@ Describe 'registry config whatif tests' {
             }
         }
 '@
-        registry config set --input $set_json
+        registry config set --input $set_json 2>$null
         $whatif_json = @'
         {
             "keyPath": "HKCU\\1\\2"
         }
 '@
-        $result = registry config set -w --input $whatif_json | ConvertFrom-Json
+        $result = registry config set -w --input $whatif_json 2>$null | ConvertFrom-Json
         $LASTEXITCODE | Should -Be 0
         $result.keyPath | Should -Be 'HKCU\1\2'
         ($result.psobject.properties | Measure-Object).Count | Should -Be 1

runcommandonset/tests/runcommandonset.get.tests.ps1

@@ -11,20 +11,20 @@ Describe 'tests for runcommandonset get' {
         }
 "@
 
-        $result = $json | dsc resource get -r Microsoft.DSC.Transitional/RunCommandOnSet -f - | ConvertFrom-Json
+        $result = $json | dsc resource get -r Microsoft.DSC.Transitional/RunCommandOnSet -f - 2>$null | ConvertFrom-Json
         $LASTEXITCODE | Should -Be 0
         $result.actualState.arguments | Should -BeExactly @('bar', 'baz')
         $result.actualState.executable | Should -BeExactly 'foo'
         $result.actualState.exitCode | Should -BeExactly 5
     }
 
     It 'Executable is a required input via CLI arguments' {
-        $null = runcommandonset get -a foo
+        $null = runcommandonset get -a foo 2>$null
         $LASTEXITCODE | Should -Be 4
     }
 
     It 'Executable is a required input via STDIN' {
-        '{ "arguments": "foo" }' | dsc resource get -r Microsoft.DSC.Transitional/RunCommandOnSet -f -
+        '{ "arguments": "foo" }' | dsc resource get -r Microsoft.DSC.Transitional/RunCommandOnSet -f - 2>$null
         $LASTEXITCODE | Should -Be 2
     }
 
@@ -39,7 +39,7 @@ Describe 'tests for runcommandonset get' {
                 arguments:
                 - "bar"
 "@
-        $out = $config_yaml | dsc config get -f - | ConvertFrom-Json
+        $out = $config_yaml | dsc config get -f - 2>$null | ConvertFrom-Json
         $LASTEXITCODE | Should -Be 0
         $out.hadErrors | Should -BeFalse
         $out.results.Count | Should -Be 1