Skip to content

Add support for the XDG specification on Linux. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tilingwm
Copy link

This adds support for the XDG specification, moving .prime from $HOME to not clutter the user's home folder.
Mac also has something similar (Claude says it's at ~/Library/Application Support) but i'm not familiar with the specifics so i would appreciate someone chiming in.

@JannikSt JannikSt requested a review from Copilot April 4, 2025 18:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/prime_cli/config.py:27

  • [nitpick] Consider constructing the path using separate components (e.g., Path.home() / ".config" / "prime") for better clarity and consistency with typical XDG path usage.
                self.config_dir = Path.home() / ".config/prime"

Copy link
Member

@JannikSt JannikSt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution and sorry for this late reply!
Could you rebase with main and run python3 -m ruff check & python3 -m ruff format?
Otherwise lgtm

@tilingwm tilingwm closed this by deleting the head repository May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants