Skip to content

Conversation

afarber
Copy link
Contributor

@afarber afarber commented Sep 24, 2025

Fix the #7253 by:

  • Add MSVC warning management to cmake/warnings.cmake
  • Suppress informational warnings while keeping bug-indicating ones
  • Fix type safety warnings in xor_fast_hash.hpp and contracted_edge_container.hpp
  • Replace -1ULL by std::numeric_limits::max()
  • Add few safe casts to fix the warning C4244

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

Suppress informational warnings while keeping bug-indicating ones
Fix type safety warnings in xor_fast_hash.hpp and contracted_edge_container.hpp
@afarber afarber changed the title Add MSVC warning management to cmake/warnings.cmake Reduce the number of MSVC warnings in CI workflow builds on Windows Sep 24, 2025
@afarber
Copy link
Contributor Author

afarber commented Sep 25, 2025

Hi @SiarheiFedartsou and @DennisOSRM currently the Build log for conan-windows-release-node is very large, sometimes even not viewable in a web browser.

Please review my PR, it reduces the number of MSVC compiler warnings significantly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants