Skip to content

158 remove colors file #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: staging
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
1027a22
feat: add Yedidya Rashi profile (#220)
Yedidyar Jun 24, 2022
554b82d
chore: remove idea folder (#236)
OmriBarZik Jul 2, 2022
5e9ea19
updating readme: custom image (#239)
shir22 Jul 2, 2022
365afa6
test: add e2e infra with playwright and a sample test (#235)
lirantal Jul 2, 2022
b452576
Yedidyar/issue167 (#240)
Yedidyar Jul 2, 2022
d7e85d9
fix(Description): wrap descriptionHeight with useEffect (#243)
Yedidyar Jul 2, 2022
44dd239
Merge branch 'master' of https://github.com/Pull-Request-Community/pu…
Yedidyar Jul 4, 2022
70aaa86
There is no background for the role of Former admin label
Yedidyar Jul 4, 2022
453f762
Merge pull request #250 from Yedidyar/Yedidyar/issue241
InbarDanieli Jul 4, 2022
6b90aa7
Test (#238)
Noamili Jun 28, 2022
d9dc2f7
Merge branch 'Pull-Request-Community:staging' into staging
Noamili Jul 8, 2022
69caacd
Merge branch 'Pull-Request-Community:staging' into staging
Noamili Jul 10, 2022
7d18ee8
remove colors.ts
noamilsh Jul 9, 2022
5c91f5e
remove un used import
noamilsh Jul 9, 2022
aa33921
fix lint issue
noamilsh Jul 10, 2022
449fdf3
fix style
noamilsh Jul 10, 2022
92e98d0
Merge branch 'Pull-Request-Community:staging' into staging
Noamili Jul 25, 2022
0891927
remove colors.ts
noamilsh Jul 9, 2022
55a70a6
fix lint issue
noamilsh Jul 10, 2022
d97a360
fix style
noamilsh Jul 10, 2022
9fd6b96
Delete Description.tsx
Noamili Jul 25, 2022
109b6e4
update colors names
noamilsh Jul 25, 2022
756fb05
add new colors
noamilsh Jul 25, 2022
d80a05d
small fix in order
noamilsh Jul 25, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 2 additions & 25 deletions components/buttons/basicButton.tsx
Original file line number Diff line number Diff line change
@@ -1,32 +1,9 @@
import colors from '../../styles/colors';
import styles from './button.module.scss';

const BasicButton = ({ children, className }: BasicButtonProps) => {
return (
<>
<button className={`${className} BasicButton`}>{children}</button>
<style jsx>{`
.BasicButton {
user-select: none;
cursor: pointer;
color: white;
font-size: 1rem;
border: none;
border-radius: 64px;
background-color: var(--primary);
display: flex;
align-items: center;
justify-content: center;
padding: 6px 12px 6px 6px;
transition: all 0.3s;
width: 126px;
height: 36px;
}

.BasicButton:hover {
filter: brightness(1.2);
transform: scale(1.02);
}
`}</style>
<button className={`${className} ${styles.basicButton}`}>{children}</button>
</>
);
};
Expand Down
69 changes: 69 additions & 0 deletions components/buttons/button.module.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
@import "../../styles/colors";

.socialButton {
user-select: none;
cursor: pointer;
color: white;
font-size: 1.5rem;
border: none;
border-radius: 100%;
padding: 10px 0;
transition: background-color 0.3s cubic-bezier(0.4, 0, 1, 1);
max-height: 36px;
max-width: 36px;
display: flex;
justify-content: center;
align-items: center;
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}

.telegram {
background-color: $blue-300;
}

.facebook {
background-color: $blue-200;
}

.discord {
background-color: $blue-100;
}

.newsletter {
background-color: $gray-400;
}

.socialButton:hover {
filter: brightness(1.2);
}

@media only screen and (max-width: 600px) {
.socialButton {
max-height: 48px;
max-width: 48px;
}
}

.basicButton {
user-select: none;
cursor: pointer;
color: white;
font-size: 1rem;
border: none;
border-radius: 64px;
background-color: var(--primary);
display: flex;
align-items: center;
justify-content: center;
padding: 6px 12px 6px 6px;
transition: all 0.3s;
width: 126px;
height: 36px;
}

.basicButton:hover {
filter: brightness(1.2);
transform: scale(1.02);
}
46 changes: 2 additions & 44 deletions components/buttons/socialButton.tsx
Original file line number Diff line number Diff line change
@@ -1,51 +1,9 @@
import colors from '../../styles/colors';
import styles from './button.module.scss';

const SocialButton = ({ children, className }: BasicButtonProps) => {
return (
<>
<button className={`${className} SocialButton`}>{children}</button>
<style jsx>{`
.SocialButton {
user-select: none;
cursor: pointer;
color: white;
font-size: 1.5rem;
border: none;
border-radius: 100%;
padding: 10px 0;
transition: background-color 0.3s cubic-bezier(0.4, 0, 1, 1);
max-height: 36px;
max-width: 36px;
display: flex;
justify-content: center;
align-items: center;
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
.telegram {
background-color: ${colors.telegram};
}
.facebook {
background-color: ${colors.facebook};
}
.discord {
background-color: ${colors.discord};
}
.newsletter {
background-color: ${colors.newsletter};
}

.SocialButton:hover {
filter: brightness(1.2);
}
@media only screen and (max-width: 600px) {
.SocialButton {
max-height: 48px;
max-width: 48px;
}
}
`}</style>
<button className={`${styles[className]} ${styles.socialButton}`}>{children}</button>
</>
);
};
Expand Down
9 changes: 9 additions & 0 deletions components/personCard/personCard.module.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
@import "../../styles/media";
@import "../../styles/colors";

.card {
width: 100%;
Expand Down Expand Up @@ -106,3 +107,11 @@
}
}
}

.card_default_theme {
border-bottom-color: $red-200;
}

.icon_default_theme {
color: $red-200;
}
17 changes: 13 additions & 4 deletions components/personCard/personCard.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { useMemo, useRef } from 'react';
import classNames from 'classnames';
import {
mdiFacebook,
mdiGithub,
Expand All @@ -11,7 +12,6 @@ import {
import Icon from '@mdi/react';
import { IPerson } from '../../services/people';
import styles from './personCard.module.scss';
import colors from '../../styles/colors';
import ShowMore from '../showMore/showMore';
import Label from '../label/label';

Expand All @@ -35,7 +35,6 @@ export function PersonCard({ person }: IPersonProps) {
roles,
customImage,
} = person;
const theme = useMemo(() => themeColor ?? colors.secondary_color, [themeColor]);
const icons = useMemo(
() => [
{ link: github, icon: mdiGithub },
Expand All @@ -54,7 +53,12 @@ export function PersonCard({ person }: IPersonProps) {
const onToggleCard = () => card?.current?.classList.toggle(styles.card__open);

return (
<div ref={card} className={styles.card} style={{ borderBottomColor: theme }}>
<div
ref={card}
className={classNames(styles.card, {
[`${styles.card_default_theme}`]: !themeColor,
})}
>
<div
className={styles.card__img}
style={{
Expand Down Expand Up @@ -94,7 +98,12 @@ export function PersonCard({ person }: IPersonProps) {
href={link.startsWith('https://') ? link : `https://github.com/${link}`}
rel="noreferrer"
>
<Icon className="icon" path={icon} style={{ color: theme }} />
<Icon
className={classNames({
[`${styles.icon_default_theme}`]: !themeColor,
})}
path={icon}
/>
</a>
)
)}
Expand Down
6 changes: 4 additions & 2 deletions components/projectPage/ProjectPage.module.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import "../../styles/colors";

.descriptionContainer {
display: flex;
flex-direction: column;
Expand All @@ -10,7 +12,7 @@
justify-content: center;
font-weight: bold;
font-size: 36px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I change this to rem?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please :)

color: #0b008e;
color: $blue-500;
}

.star {
Expand Down Expand Up @@ -60,6 +62,6 @@
}

.description {
font-size: 1.556rem; // Based on 9px.
font-size: 1rem; // Based on 16px.
}
}
4 changes: 3 additions & 1 deletion components/projectPage/technologies/Technologies.module.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import "../../../styles/colors";

.listContainer {
display: flex;
flex-direction: row;
Expand All @@ -14,6 +16,6 @@
align-items: center;
justify-content: center;
font-size: 14px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I change this to rem?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please :)

color: #e2e2e2;
color: $gray-200;
user-select: none;
}
2 changes: 1 addition & 1 deletion components/socialNetworks/socialNetworks.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
max-height: 50px;
}
&__btn {
color: #fff;
color: white;
width: 50px;
height: 50px;
border-radius: 50%;
Expand Down
31 changes: 31 additions & 0 deletions styles/colors.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
$blue-100: #7289da;
$blue-200: #1778f2;
$blue-300: #0088cc;
$blue-500: #0b008e;
$red-200: #ce5a55;
$gray-100: #e8e8e8;
$gray-200: #e2e2e2;
$gray-400: #808080;
$gray-500: #353535;
$gray-600: #292e33;
$gray-700: #242831;
$gray-800: #202529;
$gray-900: #1d1d1d;
// New colors.
$blue-600: #01007d;
$new-gray-100: #fafafb;
$new-gray-200: #e9ebef;
$new-gray-300: #bfc0c3;
$new-gray-400: #5b6375;
$new-gray-500: #39475d;
$new-gray-600: #242831;
$purple-500: #832ec6;
$purple-red-500: linear-gradient(180deg, #01007d 0%, #832ec6 47.92%, #dc665e 100%);
$purple-red-400: linear-gradient(
180deg,
rgba(1, 0, 125, 0.6) 0%,
rgba(131, 46, 198, 0.6) 47.92%,
rgba(220, 102, 94, 0.6) 100%
);
$purple-100: rgba(11, 0, 142, 0.3);
$purple-200: rgba(11, 0, 142, 0.1);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can I avoid using opacity?

7 changes: 0 additions & 7 deletions styles/colors.ts

This file was deleted.

21 changes: 11 additions & 10 deletions styles/globals.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
@import "./typography.scss";
@import "../styles/colors";

* {
box-sizing: border-box;
Expand All @@ -25,19 +26,19 @@ html {
}

html {
--primary: #ce5a55;
--background-color: #e8e8e8;
--primary: #{$red-200};
--background-color: #{$gray-100};
--background-description: white;
--card-background: white;
--header-background: #242831;
--text: #1d1d1d;
--header-background: #{$gray-700};
--text: #{$gray-900};
}

html.dark {
--primary: #ce5a55;
--background-color: #353535;
--background-description: #202529;
--card-background: #292e33;
--header-background: #000;
--text: #e8e8e8;
--primary: #{$red-200};
--background-color: #{$gray-500};
--background-description: #{$gray-800};
--card-background: #{$gray-600};
--header-background: black;
--text: #{$gray-100};
}