Skip to content

remove obj.load in getinfo #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove obj.load in getinfo #71

wants to merge 1 commit into from

Conversation

poudro
Copy link

@poudro poudro commented May 20, 2020 •
edited
Loading

fixes #70

By removing check to client.head_object in getinfo we were able to recover expected behavior where

  • open works when file exists
  • open fails with fs.errors.ResourceNotFound if file does not exist/is not accessible

@shadiakiki1986 shadiakiki1986 mentioned this pull request Jul 29, 2021
Open
@shadiakiki1986
Copy link

I think this PR should be closed as this is intended s3fs behavior as I explained here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fs.open returns ResourceNotFound (404) even though fs.exists finds the path
2 participants
@poudro @shadiakiki1986