-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[MNT] move CI to uv (assume you have a global uv/uvx installed) #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@fkiraly This is the move to uv. I have updated the pyproject.toml file for it, removed poetry.lock and created a uv.lock file with uv sync --all-extras Again, I have deactivated the linters (causing mild problems) |
|
@fkiraly this could be merged |
fkiraly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I fully support a move of CI to uv.
May I ask you though to only do one things in a PR at a time? This PR also includes changes to linting.
Also, it seems to be missing a change from pip install to uv pip install as one would expect in a PR that moves to uv?
|
Fair point to use uv pip install. |
fkiraly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is now superseded, except for the linting?
I moved the CI to uv separately.
fkiraly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are actual changes to pyproject.toml, some revert earlier changes, such as adding python 3.13 and 3.14 compatibility, isolation of soft dependencies, etc.
Can you please revert these?
Add this stage we do not yet install uv/uvx. We assume the user is familiar with uv.