[bugfix] Only compare matching length vectors #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure `length(special.days) == 1L` before comparing to `"weekends"`. This is requried for newer versions of R. As far as I can tell, this does not limit any functionality, but masks the informative error message when specifying the wrong number of days (i.e. 365 for a leap year) with an uninformative one. This commit fixes issue R-CoderDotCom#30. Signed-off-by: Marcel Schilling <foss@mschilli.com>
mschilli87
force-pushed
the
calendR-issue30
branch
from
e54152a to
557f506
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
length(special.days) == 1Lbefore comparing to"weekends". This is requried for newer versions of R.As far as I can tell, this does not limit any functionality, but masks the informative error message when specifying the wrong number of days (i.e. 365 for a leap year) with an uninformative one.
This commit fixes issue #30.
@R-CoderDotCom: I submitted calendRio v.02.1 containing this fix to CRAN and thought I offer it upstream as well.