Skip to content

Conversation

iranzo
Copy link
Member

@iranzo iranzo commented Nov 10, 2022

Removes messages about oc debug (which almost any check includes) and reduces output when no specific cards are found and just report about the ones found

Fixes #112

@dcritch
Copy link
Contributor

dcritch commented Nov 15, 2022

@iranzo Looks like your previous PR created a conflict?

@iranzo
Copy link
Member Author

iranzo commented Nov 15, 2022

@iranzo Looks like your previous PR created a conflict?

Rebased!

@ptrnull
Copy link
Contributor

ptrnull commented Nov 16, 2022

What is the goal of this PR? The message are placed in purpose to inform the user what is going on. If we remove them the user will have a false feeling that nothing is ongoing and that the tool is not doing anything. @iranzo can you clarify?

@iranzo
Copy link
Member Author

iranzo commented Nov 18, 2022

What is the goal of this PR? The message are placed in purpose to inform the user what is going on. If we remove them the user will have a false feeling that nothing is ongoing and that the tool is not doing anything. @iranzo can you clarify?

As there are checks and a wrapper that executes them, the messages about 'running XXX' should be in the wrapper and not the check itself to give a bit of consistency.

Also, if you put the message in the wrapper and not in the test, you can filter out for the actual test output and not the 'decoration' like 'please wait, etc' which is irrelevant if you're running this periodically.

I would advise towards having just output when there are errors or problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup some of the codes

3 participants