-
Notifications
You must be signed in to change notification settings - Fork 5.3k
bsp/nxp/mcx/mcxe: Add MCX E247 and FRDM-MCXE247 support. #10654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yilin Sun <imi415@imi.moe>
Signed-off-by: Yilin Sun <imi415@imi.moe>
Signed-off-by: Yilin Sun <imi415@imi.moe>
📌 Code Review Assignment🏷️ Tag: workflowReviewers: Rbb666 kurisaW supperthomas Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-09-02 13:54 CST)
📝 Review Instructions
|
@imi415 CI有个报错,请看下 |
Signed-off-by: Yilin Sun <imi415@imi.moe>
Signed-off-by: Yilin Sun <imi415@imi.moe>
Signed-off-by: Yilin Sun <imi415@imi.moe>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the NXP MCXE247 microcontroller and FRDM-MCXE247 development board to the RT-Thread BSP collection. The MCXE247 is a Cortex-M4 based microcontroller that extends RT-Thread support to NXP's MCX E series.
- Adds complete BSP structure for FRDM-MCXE247 board with all necessary configuration files
- Implements device drivers for UART, SPI, I2C, ADC, GPIO, WDT, and hardware timers
- Provides build system integration with SConstruct, SConscript, and Kconfig files
Reviewed Changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
bsp/nxp/mcx/mcxe/frdm-mcxe247/template.uvprojx | Keil μVision project template with incorrect device references |
bsp/nxp/mcx/mcxe/frdm-mcxe247/template.uvoptx | Keil μVision project options with incorrect device references |
bsp/nxp/mcx/mcxe/frdm-mcxe247/rtconfig.py | Build configuration for multiple toolchains (GCC, Keil, IAR) |
bsp/nxp/mcx/mcxe/frdm-mcxe247/rtconfig.h | RT-Thread configuration header with peripheral settings |
bsp/nxp/mcx/mcxe/frdm-mcxe247/board/linker_scripts/* | Memory layout scripts for different toolchains |
bsp/nxp/mcx/mcxe/frdm-mcxe247/board/MCUX_Config/* | NXP MCUXpresso clock and pin configuration files |
bsp/nxp/mcx/mcxe/frdm-mcxe247/applications/* | Sample application and RW007 WiFi module support |
bsp/nxp/mcx/mcxe/Libraries/drivers/* | Device drivers for UART, SPI, and WDT peripherals |
Comments suppressed due to low confidence (1)
bsp/nxp/mcx/mcxe/frdm-mcxe247/board/linker_scripts/MCXE247_flash.scf:1
- The comment states 'Multiply Factor is 28' but the actual value is set to 12, creating a mismatch between code and documentation.
#!armclang --target=arm-arm-none-eabi -mcpu=cortex-m4 -E -x c
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
本PR添加MCXE247/FRDM-MCXE247支持。相关驱动已在 RT-Thread-packages/nxp-mcx-series#2 中合并。
This PR adds support for MCXE247/FRDM-MCXE247, required drivers for this BSP was merged in RT-Thread-packages/nxp-mcx-series#2.
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up